Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect offset value for files in ZIP after 4GB #139

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed incorrect offset value for files in ZIP after 4GB #139

wants to merge 2 commits into from

Conversation

OPSnake
Copy link

@OPSnake OPSnake commented Jun 18, 2024

  • Adjusted offset calculations to correctly handle files larger than 4GB.

Related Issues

@OPSnake
Fixed incorrect offset value for files in ZIP after 4GB
719afa1 
- Adjusted offset calculations to correctly handle files larger than 4GB.
@OPSnake OPSnake force-pushed the issue/Fix-Reading-zip64-over-4Go branch from b45efc9 to 719afa1 Compare June 18, 2024 07:03
nanney54
nanney54 reviewed Jun 18, 2024
View reviewed changes
src/read.js Outdated Show resolved Hide resolved
src/read.js Outdated Show resolved Hide resolved
@heidemn-faro
Copy link

@dmattia is there any chance you could have a look at this PR, please?
With your advertisment "Zip/unzip files of any size in the browser using streams", this fix seems kind of important 😄

With this fix, I was able to unzip a 7.2 GB Zip file. Didn't work with the latest published NPM package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanney54 nanney54 nanney54 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OPSnake @heidemn-faro @nanney54