Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete CI setup #6

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Complete CI setup #6

merged 2 commits into from
Dec 20, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Dec 20, 2024

See https://github.com/actions/runner-images

and error message from build that ubuntu-latest is not supported with msbuild...

Follow up to #5

@cla-bot cla-bot bot added the cla-signed label Dec 20, 2024
@mosabua
Copy link
Member Author

mosabua commented Dec 20, 2024

@georgewfisher we will definitely have to merge this but also have to add some other stuff in the CI build since there are nuget related errors. Is there some way to run the build on macos at all?

If not I will have to set this up on my Windows desktop machine I guess ;-)

@mosabua mosabua changed the title Use Windows runner for GHA Complete CI setup Dec 20, 2024
@mosabua
Copy link
Member Author

mosabua commented Dec 20, 2024

We got a first CI build passing! Hurray .. merging away.

@mosabua mosabua merged commit 5a7e91d into trinodb:main Dec 20, 2024
2 checks passed
@mosabua mosabua deleted the windows branch December 20, 2024 20:15
@georgewfisher
Copy link
Contributor

It should be possible to build on Linux as this is .NET standard. You just need msbuild

Copy link
Contributor

@georgewfisher georgewfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants