Fix: Error with KeyboardFocusableScrollersEnabled feature when use inputs in modal dialog #41065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Thanks for submitting a PR @EstebanPina
There's an issue, as you can see in the deployed documentation of this branch.
- The modal is not rendered in the "Modal components section"
- The modal in the "Live demo" section is not centered in the page:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change position from relative to fixed in modal dialog
Motivation & Context
When you try to use an input like select2, MUI Select or SweetAlert inside modal dialog its impossible to focus the input without disable KeyboardFocusableScrollersEnabled in chromium navs
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #38515