Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(changeUserPwd/run-passwd.cpp): format security #6

Open
wants to merge 2 commits into
base: Debian
Choose a base branch
from
Open

fix(changeUserPwd/run-passwd.cpp): format security #6

wants to merge 2 commits into from

Conversation

Xeonacid
Copy link

@Xeonacid Xeonacid commented Jan 19, 2022 •
edited
Loading

Use g_error_new_literal instead of g_error_new, to fix the format string security issue.

@Xeonacid
fix(changeUserPwd/run-passwd.cpp): format security
d827d48 
Add "%s" format to g_error_new, to fix the format string security issue.
@heftig
Copy link

heftig commented Feb 12, 2022

Using g_error_new_literal instead of formatting is slightly better.

@Xeonacid @heftig
fix: use g_error_new_literal
4c08b84 
Co-authored-by: Jan Alexander Steffens <[email protected]>
@Xeonacid
Copy link
Author

@heftig fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xeonacid @heftig