Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce CometBLS wasm light client #494

Merged
merged 21 commits into from
Aug 22, 2023
Merged

Introduce CometBLS wasm light client #494

merged 21 commits into from
Aug 22, 2023

Conversation

aeryz
Copy link
Contributor

@aeryz aeryz commented Aug 16, 2023 •
edited
Loading

Partially implements #435. Membership verification is still missing.

benluelo
benluelo reviewed Aug 16, 2023
View reviewed changes
lib/unionlabs/src/tendermint/types/header.rs Show resolved Hide resolved
light-clients/cometbls-light-client/ARCHITECTURE.md Outdated Show resolved Hide resolved
light-clients/cometbls-light-client/src/zkp_verifier.rs Outdated Show resolved Hide resolved
light-clients/cometbls-light-client/src/zkp_verifier.rs Outdated Show resolved Hide resolved
lib/unionlabs/src/ibc/google/protobuf/duration.rs Outdated Show resolved Hide resolved
lib/unionlabs/src/ibc/google/protobuf/timestamp.rs Outdated Show resolved Hide resolved
lib/unionlabs/src/ibc/google/protobuf/timestamp.rs Outdated Show resolved Hide resolved
lib/unionlabs/src/ibc/lightclients/cometbls/cdc_encode.rs Outdated Show resolved Hide resolved
aeryz added 10 commits August 21, 2023 08:23
@aeryz
feat(cometbls-lc): base implementation
31142d8 
Signed-off-by: aeryz <[email protected]>
@aeryz
chore(cometbls-lc): implement proto for loads of types
43dc16b 
Signed-off-by: aeryz <[email protected]>
@aeryz
feat(cometbls-lc): implement header verification without ZKP
5cf67ac 
Signed-off-by: aeryz <[email protected]>
@aeryz
feat(cometbls-lc): implementing zkp verifier
ada8c0e 
Signed-off-by: aeryz <[email protected]>
@aeryz
chore(cometbls-lc): move type impls to unionlabs
3cd23e8 
Signed-off-by: aeryz <[email protected]>
@aeryz
chore(unionlabs): remove CdcEncode
13486c5 
Signed-off-by: aeryz <[email protected]>
@aeryz
chore(unionlabs): use official rust implementation for `Duration::che…
c2739ce 
…cked_add`

Signed-off-by: aeryz <[email protected]>
@aeryz
chore(unionlabs): implement TryFrom<cosmwasm::Timestamp> for `Times…
39efbc7 
…tamp`

Signed-off-by: aeryz <[email protected]>
@aeryz
chore(unionlabs): convert as to unwrap when integer conversion
aaf6498 
Signed-off-by: aeryz <[email protected]>
@aeryz
chore(cometbls-lc): remove ethereum-lc related things
2e67f1a 
Signed-off-by: aeryz <[email protected]>
@aeryz aeryz force-pushed the 435-wasm-cometbls-client branch from 3faa4d5 to 2e67f1a Compare August 21, 2023 06:12
@hussein-aitlahcen hussein-aitlahcen marked this pull request as ready for review August 22, 2023 14:53
benluelo
benluelo previously requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@benluelo benluelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the unionlabs type conversions need to be cleaned up, otherwise lgtm

lib/cometbls-groth16-verifier/src/lib.rs Outdated Show resolved Hide resolved
lib/cometbls-groth16-verifier/src/lib.rs Outdated Show resolved Hide resolved
lib/unionlabs/src/ibc/google/protobuf/duration.rs Show resolved Hide resolved
lib/unionlabs/src/ibc/google/protobuf/timestamp.rs Show resolved Hide resolved
lib/unionlabs/src/ibc/google/protobuf/timestamp.rs Outdated Show resolved Hide resolved
lib/unionlabs/src/ibc/lightclients/cometbls/header.rs Outdated Show resolved Hide resolved
lib/unionlabs/src/ibc/lightclients/cometbls/header.rs Show resolved Hide resolved
lib/unionlabs/src/tendermint/types/commit.rs Outdated Show resolved Hide resolved
lib/unionlabs/src/tendermint/types/commit_sig.rs Outdated Show resolved Hide resolved
light-clients/cometbls-light-client/src/contract.rs Show resolved Hide resolved
@aeryz aeryz changed the title Introduce CometBLS wasm light client Introduce CometBLS wasm light client (closes #435) Aug 22, 2023
@aeryz aeryz changed the title Introduce CometBLS wasm light client (closes #435) Introduce CometBLS wasm light client Aug 22, 2023
@aeryz aeryz dismissed benluelo’s stale review August 22, 2023 18:30

he's ooo rn, and he approved that he'll create a follow up PR

@aeryz aeryz merged commit b8819a5 into main Aug 22, 2023
@aeryz aeryz deleted the 435-wasm-cometbls-client branch August 22, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiserKarel KaiserKarel KaiserKarel left review comments

@PoisonPhang PoisonPhang PoisonPhang approved these changes

@benluelo benluelo benluelo left review comments

@hussein-aitlahcen hussein-aitlahcen hussein-aitlahcen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aeryz @hussein-aitlahcen @PoisonPhang @KaiserKarel @benluelo