feat: add support for generating sourcemaps #276
+104
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryan-hoang
commented
Dec 20, 2024
Comment on lines
+291
to
+295
| "dist/components/script-multi-block.vue.mjs.map", | ||
| "dist/components/script-setup-ts.vue", | ||
| "dist/components/script-setup-ts.vue.mjs.map", | ||
| "dist/components/ts.vue", | ||
| "dist/components/ts.vue.mjs.map", |
There was a problem hiding this comment.
I'm unsure about the generation of the *.vue.mjs.map files, as I haven't worked with .vue files before.
bryan-hoang
commented
Dec 20, 2024
| const { writtenFiles } = await mkdist({ | ||
| rootDir, | ||
| esbuild: { | ||
| sourcemap: "linked", |
There was a problem hiding this comment.
I only added a test case with the "linked" option since that's what I'm personally interested in, and I wasn't sure how the option would change if esbuild were to be swapped out with rolldown. I'd be happy to add test cases for the other modes if deemed necessary.
The CLI now accepts a `--sourcemap` option that should match the behaviour of `esbuild`'s `--sourcemap` option. The programmatic API's `esbuild.sourcemap` option should now also match with `esbuild`'s `sourcemap` option for the Build API. The `sourcemap: 'linked'` option is special cased in the implementation, since `esbuild` doesn't support the option under the Transform API that `mkdist` uses [^1]. Refs: https://esbuild.github.io/api/#sourcemap Refs: https://sourcemaps.info/spec.html [^1]: https://github.com/evanw/esbuild/blob/745abd9f0c06f73ca40fbe198546a9bc36c23b81/pkg/api/api_impl.go#L1749
bryan-hoang
force-pushed
the
feature/sourcemap-generation
branch
from
f9d2746 to
40bded1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #164
The CLI now accepts a
--sourcemapoption that should match the behaviour ofesbuild's--sourcemapoption. The programmatic API'sesbuild.sourcemapoption should now also match withesbuild'ssourcemapoption for the Build API.The
sourcemap: 'linked'option is special cased in the implementation, sinceesbuilddoesn't support the option under the Transform API thatmkdistuses 1.Refs: https://esbuild.github.io/api/#sourcemap
Refs: https://sourcemaps.info/spec.html
Footnotes
https://github.com/evanw/esbuild/blob/745abd9f0c06f73ca40fbe198546a9bc36c23b81/pkg/api/api_impl.go#L1749 ↩