fix(module): Handle X.Y.Z version format #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting Go 1.21, the 'go' directive in go.mod files
takes the form:
go X.Y.Z
(https://go.dev/doc/go1.21)
Given a go.mod file with such a directive,
`gimme module` fails because it turns "1.21.5" into "1.21.5.x".
This commit fixes the issue by adding the ".x" suffix
only if the version is in the form "X.Y".
As an added bonus, this will also work for pre-releases:
go 1.22rc2
abhinav
force-pushed
the
handle-1.21-versions
branch
from
2a0a55b to
3f9da19
Compare
brackendawson
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
Initially I thought this behaviour might be a regression, since the go directive is now defined as a strict minimum supported version. I thought it should continue to use the latest patch release as it did before.
However thinking about why this feature was created, to allow one to reliably test a module with it's minimum supported version, then this behaviour is desirable. Thank you.
abhinav
added a commit
to abhinav/gimme
that referenced
this pull request
Feb 6, 2024
abhinav
added a commit
to abhinav/gimme
that referenced
this pull request
Feb 6, 2024
abhinav
added a commit
to abhinav/gimme
that referenced
this pull request
Feb 6, 2024
abhinav
added a commit
to abhinav/gimme
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting Go 1.21, the 'go' directive in go.mod files
takes the form:
(https://go.dev/doc/go1.21)
Given a go.mod file with such a directive,
gimme modulefails because it turns "1.21.5" into "1.21.5.x".This commit fixes the issue by adding the ".x" suffix
only if the version is in the form "X.Y".
As an added bonus, this will also work for pre-releases: