feat: Add interfaces for CRUD services #20743
Conversation
Artur-
force-pushed
the
crud-interfaces
branch
from
b433077 to
83ece96
Compare
These were previously in Hilla but are equally useful in Flow applications
Artur-
force-pushed
the
crud-interfaces
branch
from
83ece96 to
8ebca25
Compare
vaadin-spring/src/main/java/com/vaadin/flow/spring/data/jpa/CrudRepositoryService.java
Outdated
Show resolved
Hide resolved
vaadin-spring/src/main/java/com/vaadin/flow/spring/data/jpa/JpaFilterConverter.java
Outdated
Show resolved
Hide resolved
...-spring/src/main/java/com/vaadin/flow/spring/data/jpa/PropertyStringFilterSpecification.java
Outdated
Show resolved
Hide resolved
vaadin-spring/src/main/java/com/vaadin/flow/spring/data/jpa/JpaFilterConverter.java
Outdated
Show resolved
Hide resolved
vaadin-spring/src/main/java/com/vaadin/flow/spring/data/FormService.java
Show resolved
Hide resolved
| @@ -0,0 +1,2 @@ | |||
| @org.springframework.lang.NonNullApi | |||
| package com.vaadin.flow.spring.data.jpa; | |||
There was a problem hiding this comment.
Maybe also add @NullMarked from JSpecify?
There was a problem hiding this comment.
If removing @NonNullApi does not break anything, then by all means remove it.
There was a problem hiding this comment.
On the contrary, Hilla only supports @NonNullApi
| @@ -0,0 +1,2 @@ | |||
| @org.springframework.lang.NonNullApi | |||
| package com.vaadin.flow.spring.data; | |||
vaadin-spring/src/main/java/com/vaadin/flow/spring/data/ListService.java
Outdated
Show resolved
Hide resolved
| @JsonSubTypes({ @Type(value = OrFilter.class, name = "or"), | ||
| @Type(value = AndFilter.class, name = "and"), | ||
| @Type(value = PropertyStringFilter.class, name = "propertyString") }) | ||
| public class Filter implements Serializable { |
There was a problem hiding this comment.
Are the Filter classes meant to mainly be created by Jackson, or is there a situation where a developer may want to create them in Java as well? Also why are the Filter classes mutable and not immutable?
There was a problem hiding this comment.
I need to create some examples to show usage before this is merged. I think they should be public and ok to create by hand but they don't need to be mutable
| @@ -0,0 +1,2 @@ | |||
| @org.springframework.lang.NonNullApi | |||
There was a problem hiding this comment.
Consider adding @NullMarked here.
vaadin-spring/src/main/java/com/vaadin/flow/spring/data/jpa/CrudRepositoryService.java
Show resolved
Hide resolved
...-spring/src/main/java/com/vaadin/flow/spring/data/jpa/PropertyStringFilterSpecification.java
Show resolved
Hide resolved
|
These were previously in Hilla but are equally useful in Flow applications