Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix. stats manager may cause crash when stats with new labels. #5933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UndefinedSy
Copy link

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

5932

Description:

when continuously adding new labels to statsManager's nameMap_, one may crash on using the previously returned iterator from nameMap_.

How do you solve it?

using read lock to protect the iterator returned from sm.nameMap_, which is a std::unordered_map.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

process will not crash on using statsManager.

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Fixed the bug that process crashes on concurrent accessing stats manager's nameMap_.

@zhanghuidinah zhanghuidinah requested a review from jievince August 22, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant