APP-6033: Add previous page token pagination to logs #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcook-viam
added
the
ready-for-protos
davidcook-viam
added
bug
davidcook-viam
added
bug
davidcook-viam
added
bug
RoxyFarhad
reviewed
Sep 9, 2024
| @@ -651,6 +651,7 @@ message GetRobotPartLogsRequest { | |||
| message GetRobotPartLogsResponse { | |||
| repeated common.v1.LogEntry logs = 1; | |||
| string next_page_token = 2; | |||
| optional string previous_page_token = 3; | |||
There was a problem hiding this comment.
does this match the scope? Can you link it
There was a problem hiding this comment.
There was a problem hiding this comment.
oh I meant the scope doc API change: Kim's doc that was approved in doc scope review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the optional string
previous_page_tokento theGetRobotPartLogsResponseproto.When this token is present in the response, it can be passed back into the
GetRobotPartLogsRequestto paginate to the previous page, used for live log tailing.