DOCS-3168: Add two new features for crop transform camera #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sguequierre
commented
Dec 19, 2024
sguequierre
commented
- proportional cropping and overlay crop box
viambot
added
the
safe to build
npentrel
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
LGTM - It may be worth considering taking all the possibel transformations out of the table (that is the classification, crop, depth edges etc) and instead having them be individual h3s with the respective content. One of the consistent pieces of feedback has been that the amount of tables makes the content harder to navigate.
|
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3773 |
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.