Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard against go version linter breakage #3914

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abe-winter
Copy link
Member

@abe-winter abe-winter commented May 7, 2024

Checklist

  • I think we also need to version the linter cache (sigh). come up with a test case that shows this, then look at env vars

What changed

  • add GOVERSION string to the bin/gotools path

Why

On local machines, a golangci-lint build from a previous go version can fail mysteriously. Folks have wasted a lot of energy debugging this.

There is a chance this still won't work -- we are crossing our fingers that the golangci-lint cache is not broken by the rebuild.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants