DATA-3072-split-prog-and-capture-files #4431
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
nicksanford
force-pushed
the
DATA-3072-split-prog-and-capture-files
branch
from
4ca3aba to
215ebb8
Compare
viambot
added
safe to test
nicksanford
force-pushed
the
DATA-3072-split-prog-and-capture-files
branch
from
215ebb8 to
ce4600f
Compare
viambot
added
safe to test
viambot
added
safe to test
nicksanford
commented
Oct 31, 2024
| } | ||
|
|
||
| // WriteNext writes the next SensorData reading. | ||
| func (f *ProgFile) WriteNext(data *v1.SensorData) error { |
There was a problem hiding this comment.
nicksanford
commented
Oct 31, 2024
| } | ||
|
|
||
| // NewProgFile creates a new *ProgFile with the specified md in the specified directory. | ||
| func NewProgFile(dir string, md *v1.DataCaptureMetadata) (*ProgFile, error) { |
There was a problem hiding this comment.
nicksanford
commented
Oct 31, 2024
| } | ||
|
|
||
| // Size returns the size of the file. | ||
| func (f *ProgFile) Size() int64 { |
There was a problem hiding this comment.
nicksanford
commented
Oct 31, 2024
| } | ||
|
|
||
| // Close closes the file. | ||
| func (f *ProgFile) Close() error { |
There was a problem hiding this comment.
nicksanford
commented
Oct 31, 2024
| @@ -448,3 +448,5 @@ require ( | |||
| github.com/ziutek/mymysql v1.5.4 // indirect | |||
| golang.org/x/exp v0.0.0-20240904232852-e7e105dedf7e | |||
| ) | |||
|
|
|||
| replace go.viam.com/api => /Users/nicksanford/code/api | |||
nicksanford
commented
Oct 31, 2024
| @@ -1645,8 +1645,6 @@ go.uber.org/zap v1.18.1/go.mod h1:xg/QME4nWcxGxrpdeYfq7UvYrLh66cuVKdrbD1XF/NI= | |||
| go.uber.org/zap v1.23.0/go.mod h1:D+nX8jyLsMHMYrln8A0rJjFt/T/9/bGgIhAqxv5URuY= | |||
| go.uber.org/zap v1.27.0 h1:aJMhYGrd5QSmlpLMr2MftRKl7t8J8PTZPA732ud/XR8= | |||
| go.uber.org/zap v1.27.0/go.mod h1:GB2qFLM7cTU87MWRP2mPIjqfIDnGu+VIO4V/SdhGo2E= | |||
| go.viam.com/api v0.1.348 h1:pLT6UiYaAvt8ckx2KA38MvyBU1s/KoiGn4/vzC/T2uU= | |||
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.