RSDK-9345 Deduplicate noisy logs #4564
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
dgottlieb
reviewed
Nov 19, 2024
| if imp.dedupNoisyLogs { | ||
| // If we have have entered a new recentMessage window, output noisy logs from | ||
| // the last window. | ||
| if time.Since(imp.recentMessageWindowStart) > noisyMessageWindowDuration { |
There was a problem hiding this comment.
I know this is not a PR, but just noting that I think most of this code would need to be wrapped in a lock.
There was a problem hiding this comment.
Yeah totally correct, will want a more "careful" implementation eventually.
viambot
added
safe to test
benjirewis
force-pushed
the
dedupe-logs
branch
from
7696072 to
ffde341
Compare
viambot
added
safe to test
benjirewis
force-pushed
the
dedupe-logs
branch
from
ffde341 to
d55ea23
Compare
benjirewis
force-pushed
the
dedupe-logs
branch
from
d55ea23 to
afe9b2e
Compare
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
benjirewis
commented
Dec 23, 2024
| if imp.dedupNoisyLogs { | ||
| // If we have have entered a new recentMessage window, output noisy logs from | ||
| // the last window. | ||
| if time.Since(imp.recentMessageWindowStart) > noisyMessageWindowDuration { |
| assertLogMatches(t, notStdout, | ||
| `2023-10-30T13:19:45.806Z INFO impl logging/impl_test.go:132 foo {"key":"value"}`) | ||
|
|
||
| // TODO(benji): Add the following assertions to test more deduplication logic. |
There was a problem hiding this comment.
Still working on testing a bit, but thought I'd throw this into review before the holiday.
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSDK-9345
Main changes:
disable_log_deduplicationJSON flag to potentially disable the logic described in the above two pointsTesting changes: