[APP-7307]: Remove logo file path manipulation in CLI for OrganizationSetLogo. #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side handler anyway).
viambot
added
the
safe to test
|
Validated it works: |
jr22
reviewed
Dec 20, 2024
| @@ -345,15 +344,7 @@ func (c *viamClient) organizationLogoSetAction(cCtx *cli.Context, orgID, logoFil | |||
| if err := c.ensureLoggedIn(); err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| // determine whether this is a valid file path on the local system | |||
| logoFilePath = strings.ToLower(filepath.Clean(logoFilePath)) | |||
jr22
reviewed
Dec 20, 2024
cli/client.go
Outdated
| } | ||
|
|
||
| logoFile, err := os.Open(logoFilePath) | ||
| logoFile, err := os.Open(logoFilePath) //nolint:gosec |
There was a problem hiding this comment.
what is the linter complaining about for security
There was a problem hiding this comment.
If I add filepath.Clean maybe it won't be necessary - but yeah really didn't know what / why needed
jr22
reviewed
Dec 20, 2024
Comment on lines
-352
to
-353
| if len(logoFilePath) < 5 || logoFilePath[len(logoFilePath)-4:] != ".png" { | ||
| return errors.Errorf("%s is not a valid .png file path", logoFilePath) |
There was a problem hiding this comment.
why remove? because it might be a png but not have png ending?
There was a problem hiding this comment.
we do this checking server side so agree we dont necessarily need it here
There was a problem hiding this comment.
Duplicated validation thats not as thorough as what we have in the BE because of that reason
viambot
added
safe to test
jr22
approved these changes
Dec 20, 2024
njooma
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://viam.atlassian.net/browse/APP-7307