RSDK-9556 Forward declarations for grpc Client stuff #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lia-viam
requested review from
njooma and
stuqdog
and removed request for
a team
lia-viam
changed the title
stuqdog
approved these changes
Dec 18, 2024
| // Forward declaration file for grpc ClientContext and ClientReaderInterface<T>. | ||
| // This file provides includes for recent (>= 1.32.0) versions of grpc. | ||
|
|
||
| namespace grpc { |
There was a problem hiding this comment.
(q) why is the namespace grpc here but grpc_impl in the else case below?
There was a problem hiding this comment.
In recent versions of grpc the classes are defined in namespace grpc, but in the oldest two versions we support the class definitions are in namespace grpc_impl and typedef'd into namespace grpc, which is incompatible with forward declaring the classes in namespace grpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is based off the currently open misc-proto-update branch