Motor #29
Merged
Motor #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
requested review from
stuqdog and
purplenicole730
and removed request for
a team
stuqdog
approved these changes
May 14, 2024
Comment on lines
84
to
86
| * Regardless of the directionality of the [rpm] this function will move | ||
| * the motor towards the specified position. | ||
| * @param rpm speed at which the motor should move in rotations per minute (negative implies backwards) |
There was a problem hiding this comment.
Maybe I misunderstand what we mean by "directionality", but it seems to me that we're first saying that a negative RPM won't affect the direction, but then the param docstring states the opposite.
There was a problem hiding this comment.
Nope you are correct I fixed the javadoc prior to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add motor wrappers and tests