DOCS-2347: Update example on GetLatestTabularData #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sguequierre
commented
Dec 20, 2024
sguequierre
commented
- feedback from bill where he wanted example values in the example
- tested out example
stuqdog
reviewed
Dec 23, 2024
| ) | ||
|
|
||
| if tabular_data and len(tabular_data) == 3: |
There was a problem hiding this comment.
Suggested change
| if tabular_data and len(tabular_data) == 3: | |
| if tabular_data: |
(minor) I think the len check here is unnecessary, since the return value will always be either None or a tuple of length 3.
There was a problem hiding this comment.
Gotcha, if I run without the check though and it returns None I get this error TypeError: cannot unpack non-iterable NoneType object. Is that expected/ok?
stuqdog
approved these changes
Dec 23, 2024
stuqdog
reviewed
Dec 23, 2024
| resource_subtype="<RESOURCE-SUBTYPE>", | ||
| method_name="<METHOD-NAME>" | ||
| tabular_data = await data_client.get_latest_tabular_data( | ||
| part_id="77ae3145-7b91-123a-a234-e567cdca8910", |
There was a problem hiding this comment.
(q) is this a real part-id? Is there any reason we might want to redact it?
There was a problem hiding this comment.
Not a real part-id!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.