Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not adjust delay if retry_after < delay #519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bahaa32
Copy link

@bahaa32 bahaa32 commented Jul 4, 2023

As it stands, it appears that the delete delay could be lowered when that may have not been the intention (the comment on the line says // increase delay). This PR adds a check before adjusting the delete delay such that it will only ever increase.

Possible issues:

  • If the user starts the deletion process and leaves it unattended, a long retry_after response could unexpectedly cripple the deletion speed without the possibility of the delay decreasing to a more sane value.

Perhaps it is time to algorithmically discover the rate limit? #386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant