Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop attempting to delete CHAT_INPUT_COMMAND (Type 20) messages + Adjust delete delay after ratelimit to compensate ontop of current delay #527

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MDL-cmd
Copy link

@MDL-cmd MDL-cmd commented Jul 15, 2023

Undiscord attempts to delete Non-Ethereal Slash Commands (Type 20) due to blanket checking for System Messages with (msg.type >= 6 && msg.type <= 21).

This also adjusts so the ratelimit duration is added on top of the current delete delay, which will in worst case scenarios bump the delay to 1700 (but will avoid almost every ratelimit thereafter, tested with a 4000+ job archive deletion).

…ust delete delay after ratelimit to compensate ontop of current delay
@Bikatr7
Copy link

Bikatr7 commented Aug 17, 2023

Thanks so much, this works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants