fix(css): avoid using default export from sass-embedded

[cod1r]

fixes #19052

I pray that this doesn't mess anything else up :)

[sapphi-red]

While I wasn't able to reproduce it, the default export seems to be deprecated, so I think we should avoid using it anyways.
https://sass-lang.com/documentation/breaking-changes/default-export/

[cod1r]

You most likely need to have sass-embedded installed first; but yay...

[hi-ogawa]

There was a similar issue in #17880. As I commented in the previous PR, sassPath here is the result of require.resolve, so that should be always cjs entry of sass or sass-embedded. We might need to keep .default as a fallback for sass since it doesn't look like it's compatible with cjs named export lexer.

references

• https://publint.dev/[email protected]
• https://cdn.jsdelivr.net/npm/[email protected]/dist/lib/index.js (sass-embedded cjs entry)
• https://publint.dev/[email protected]
• https://cdn.jsdelivr.net/npm/[email protected]/sass.node.js (sass cjs entry)

I still have no idea why .default fails for some users.

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/vite@19053

commit: 3745309

see hi-ogawa's comment

[cod1r]

I might be wrong but the code I changed is in a function that is only called if the sassPackage is sass-embedded. It calls different functions based on config api options in css.ts

https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/css.ts#L2575

[cod1r]

the code that handles the specific sass package is different

[hi-ogawa]

I might be wrong but the code I changed is in a function that is only called if the sassPackage is sass-embedded. It calls different functions based on config api options in css.ts

sass users can also specify api: "modern-compiler" explicitly, so the code path you mentioned is relevant for both sass and sass-embedded. Here is the repro:

• https://github.com/hi-ogawa/reproductions/tree/main/vite-sass-default-export (this one is failing with this PR)
• https://github.com/hi-ogawa/reproductions/tree/main/vite-sass-embedded-default-export

[cod1r]

I added a conditional check. Maybe that fixes this situation a little better?