Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Enable decord to load video from base64 #11492

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Dec 25, 2024

Currently, only base64 URLs based on image frames are supported because pillow is always being used to decode the individual frames. This PR enables the use of decord to load the video (just like the case for HTTP URLs) so that other types of videos can also be passed in online inference.

FIX #10994 (comment)

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 25, 2024
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

vllm/multimodal/utils.py Outdated Show resolved Hide resolved
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 changed the title [Frontend] Use decord instead of pillow to load video from base64 [Frontend] Enable decord to load video from base64 Dec 25, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 25, 2024 14:53
@DarkLight1337 DarkLight1337 merged commit b689ada into vllm-project:main Dec 25, 2024
53 checks passed
@DarkLight1337 DarkLight1337 deleted the video-base64 branch December 26, 2024 02:24
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Usage]: Qwen/Qwen2-VL-7B-Instruct
2 participants