🐛 Introduce spec.network.domainName #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
fix/issue-485
branch
2 times, most recently
from
12e879e to
2f98dfd
Compare
akutz
force-pushed
the
fix/issue-485
branch
15 times, most recently
from
4347684 to
d998adc
Compare
akutz
commented
May 1, 2024
bryanv
reviewed
May 1, 2024
bryanv
approved these changes
May 1, 2024
This patch introduces a distinct field for setting a guest's domain name, spec.network.domainName. This new field also replaces spec.bootstrap.sysprep.sysprep.identity.joinDomain from v1alpha2. There are conversions in place so that the values are copied seamlessly between the two schema versions. Additionally, there are now validation webhooks for both the values of spec.network.hostName and spec.network.domainName.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch introduces a distinct field for setting a guest's domain name,
spec.network.domainName. This new field also replacesspec.bootstrap.sysprep.sysprep.identity.joinDomainfrom v1alpha2. There are conversions in place so that the values are copied seamlessly between the two schema versions. Additionally, there are now validation webhooks for both the values ofspec.network.hostNameandspec.network.domainName.Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #485
Are there any special notes for your reviewer:
./api/v1alpha2/sysprep/conversionand its sub-directories, please see Conversion should allow explicit declaration of conversion funcs, beyond just naming convention kubernetes/code-generator#172.IsValidHostNameandIsValidDomainNamefunctions, please see https://github.com/vmware-tanzu/vm-operator/pull/487/files#diff-14bcaeb3749d37e094be80f6d45cf06ccecc4af15976dbfd75f5ab3ff0a6bb5bR21-R62.Please add a release note if necessary:
📚 Documentation preview 📚: https://vm-operator--487.org.readthedocs.build/en/487/