Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Add warning message if prop type=null and value=null #12571

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jamesnakagawa
Copy link

Description

Adds a warning when the prop's type=null and the value is also null or undefined.

Motivation

defineProps will generate type=null if the static type cannot be compiled into a basic type. However, this also means null values will be allowed even though the prop is required.

See a live demo of the bug here

Motivation: defineProps will generate type=null if the static type
cannot be inferred into a basic type. However, this also disables
required checking.

Adds a warning when the prop's type=null and the value is also null.
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.9 kB 34.2 kB
vue.global.prod.js 158 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.6 kB 18.3 kB 16.7 kB
createApp 54.6 kB 21.3 kB 19.4 kB
createSSRApp 58.7 kB 23 kB 20.9 kB
defineCustomElement 59.4 kB 22.8 kB 20.8 kB
overall 68.4 kB 26.4 kB 24 kB

Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12571

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12571

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12571

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12571

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12571

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12571

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12571

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12571

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12571

vue

npm i https://pkg.pr.new/vue@12571

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12571

commit: 5d65b1e

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔩 p2-edge-case labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 p2-edge-case ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants