fix(types): fix props type error with js script #13063
Open
+51
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
main
branch for v2.x (or to a previous version branch)fix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
When I write a sfc file with js, the type of props inference to
any
.The
defineComponent
function allows aProps
type to be passed in.All work fine with
ts
because if not actively passed in this type, the default props type isunkonwn
.But when I use
js
to write the code, the default type isany
! I think it might be a typescript problem.I think the problem that went wrong is here.
https://github.com/vuejs/vue/blob/main/types/v3-define-component.d.ts#L153
https://github.com/vuejs/vue/blob/main/types/common.d.ts#L15
I think Props type should be not defined when it is
any
. And in that case, typescript would infer the actual type of the props.