fix(types): backport fix for withDefaults when used together with generics
#13223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francis-switcho
force-pushed
the
backport-fix-for-generics-usage
branch
from
a56d621 to
f6aea2f
Compare
francis-switcho
changed the title
withDefaults when used together with generics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change? (check one)
There's a potential breaking change: defaults using a generic type must be declared via
() => Tinstead ofTeven if they're primitive types.The PR fulfills these requirements:
mainbranch for v2.x (or to a previous version branch)Other information:
This PR is nothing but a backport of vuejs/core#8335 by @pikax to the Vue 2 codebase, fixing support for generics when using the
withDefaultshelper since we're relying on it to ease our migration from Vue 2 to Vue 3. I take no merit whatsoever besides taking the time to apply it to the Vue 2 codebase and test if it works.Please let me know if it can be merged!