Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ARIA11 to address issue #1308 #2339

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Update ARIA11 to address issue #1308 #2339

merged 5 commits into from
Dec 13, 2024

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented Apr 29, 2022

Adds text for ARIA 1.2 form role.

Closes #1308

Adds text for ARIA 1.2 form role.
@fstrr fstrr requested a review from alastc April 29, 2022 20:19
@@ -26,7 +26,7 @@ <h1>Using ARIA landmarks to identify regions of a page</h1>
<li><code class="language-html">navigation</code>: A region that contains navigation links links to other pages or different parts of the same page.</li>
<li><code class="language-html">main</code>: A region that contains a page's main content.</li>
<li><code class="language-html">region</code>: A region that contains a perceivable section of the page containing content that is sufficiently important for users to be able to navigate to the section. A <code class="language-html">region</code> landmark isn't exposed as a landmark region unless it has an accessible name.</li>
<li><code class="language-html">form</code>: A region of the document that represents a collection of form-associated elements, some of which can represent editable values that can be submitted to a server for processing.</li>
<li><code class="language-html">form</code>: A region of the document that represents a collection of form-associated elements, some of which can represent editable values that can be submitted to a server for processing. It maps to <code class="language-html">form</code> in HTML, and needs an accessible name to be exposed as a landmark.</li>
Copy link
Member

@scottaohara scottaohara Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not against the idea of mentioning what element this maps to in html - but now this is the only one that does.

if adding those references to the other landmarks, that's a bit out of scope.... and if this PR goes out of scope, there are a bunch of other nits i have with this doc.

should we make all those updates now, or just address the issue specifically - and then make those other changes (including referencing the HTML elements the landmarks can be exposed from) in another PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends! I'm increasingly not a fan of PRs that wander off topic, but if it's just a couple of minor things then we could add them. I could also back out the mapping content to put in another PR if your bunch of nits is large.

Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing my review to an approval - since any issues i have with this doc are out of scope for this PR

@stes-acc
Copy link

stes-acc commented Oct 21, 2024

Why not simply referencing respective mapping locations in ARIA in HTML spec? Or just adding a sentence "For HTML mappings of ARIA landmark roles, see respective entries in table in https://www.w3.org/TR/html-aria/#docconformance".

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 5a2bacb
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/675cb85131cd03000707c642
😎 Deploy Preview https://deploy-preview-2339--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bruce-usab
Copy link
Contributor

Discussed on TF call 11/22. One minor edit made during call. This will be one worth highlighting on AG call 11/3.

@mbgower mbgower merged commit 784d405 into main Dec 13, 2024
1 check passed
@mbgower mbgower deleted the fstrr-patch-4 branch December 13, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARIA11: Add clause about form role needing an accessible label
5 participants