-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ARIA11 to address issue #1308 #2339
Conversation
Adds text for ARIA 1.2 form role.
# Conflicts: # techniques/aria/ARIA11.html
techniques/aria/ARIA11.html
Outdated
@@ -26,7 +26,7 @@ <h1>Using ARIA landmarks to identify regions of a page</h1> | |||
<li><code class="language-html">navigation</code>: A region that contains navigation links links to other pages or different parts of the same page.</li> | |||
<li><code class="language-html">main</code>: A region that contains a page's main content.</li> | |||
<li><code class="language-html">region</code>: A region that contains a perceivable section of the page containing content that is sufficiently important for users to be able to navigate to the section. A <code class="language-html">region</code> landmark isn't exposed as a landmark region unless it has an accessible name.</li> | |||
<li><code class="language-html">form</code>: A region of the document that represents a collection of form-associated elements, some of which can represent editable values that can be submitted to a server for processing.</li> | |||
<li><code class="language-html">form</code>: A region of the document that represents a collection of form-associated elements, some of which can represent editable values that can be submitted to a server for processing. It maps to <code class="language-html">form</code> in HTML, and needs an accessible name to be exposed as a landmark.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not against the idea of mentioning what element this maps to in html - but now this is the only one that does.
if adding those references to the other landmarks, that's a bit out of scope.... and if this PR goes out of scope, there are a bunch of other nits i have with this doc.
should we make all those updates now, or just address the issue specifically - and then make those other changes (including referencing the HTML elements the landmarks can be exposed from) in another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends! I'm increasingly not a fan of PRs that wander off topic, but if it's just a couple of minor things then we could add them. I could also back out the mapping content to put in another PR if your bunch of nits is large.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing my review to an approval - since any issues i have with this doc are out of scope for this PR
Why not simply referencing respective mapping locations in ARIA in HTML spec? Or just adding a sentence "For HTML mappings of ARIA landmark roles, see respective entries in table in https://www.w3.org/TR/html-aria/#docconformance". |
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Discussed on TF call 11/22. One minor edit made during call. This will be one worth highlighting on AG call 11/3. |
Adds text for ARIA 1.2 form role.
Closes #1308