Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Crackboard support #8978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Crackboard support #8978

wants to merge 1 commit into from

Conversation

nafey
Copy link

@nafey nafey commented Sep 22, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is a client for supporting crackboard.dev which is a leaderboard for programmers. This allows Sublime Text users to compete on crackboard.dev leaderboard.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Crackboard
Results help

Packages added:
  - Crackboard

Processing package "Crackboard"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

@braver
Copy link
Collaborator

braver commented Nov 30, 2024

Some remarks:

  • Access to the settings file should be possible via the package settings menu.
  • Since this adds global event listeners, I would like to see users have some more control over when that runs. You want to be able to turn that off situationally or per project. The only way right now is to turn the package off or uninstall it, and reload ST. This could be as simple as an on/off boolean in the settings: such settings can be easily toggled using commands, keybindings, and even project settings.
  • Calling the API on every text change might be a bit overkill for what crackboard needs. You might want to look into optimizing, or debouncing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants