Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use number input type as example for non-auto-directionality form-associated input element #49795

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vinhill
Copy link
Contributor

@vinhill vinhill commented Dec 20, 2024

The subtest ensures that the text direction reverts to ltr if an input element stops being auto-directionality form-associated. For this, the test changes an input element's type to month. Gecko and WebKit do not support type=month and therefore fail the test. This change uses type=number instead so that both pass the subtest.

Gecko and WebKit do not support `type=month`, so use `type=number` as an example for an input type that is not [auto-directionality form-associated](https://html.spec.whatwg.org/#auto-directionality-form-associated-elements)
@jgraham
Copy link
Contributor

jgraham commented Dec 20, 2024

AFAICT this is reasonable since the original test doesn't really care what kind of form element it is. @dbaron is the original test author, so I'll give him a chance to comment before approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants