[Reland] Handle appearance value changes during <select> showPicker. #49815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the appearance value changes as the result of the picker
opening (e.g. via `::picker(select):open {appearance:auto}` or
similar), we close the picker to avoid any oscillation or
nonsensical behavior. This CL implements this change.
The original CL [1] was reverted due to a strange bot failure [2]
where the new set of promise_tests somehow fail because
blink_wpt_tests is expecting an expectation file with a single blank
line. I added a "Failure" expectation to hopefully avoid that, in
Patchset 3.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/6094831
[2] https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/50289/overview
Fixed: 376097114,370536090,367426156
Bug: 384394713
Change-Id: I2ab4e43db3de4b7125b564c366fe86bdf9f85cc4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the appearance value changes as the result of the picker
opening (e.g. via
::picker(select):open {appearance:auto}orsimilar), we close the picker to avoid any oscillation or
nonsensical behavior. This CL implements this change.
The original CL [1] was reverted due to a strange bot failure [2]
where the new set of promise_tests somehow fail because
blink_wpt_tests is expecting an expectation file with a single blank
line. I added a "Failure" expectation to hopefully avoid that, in
Patchset 3.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/6094831
[2] https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/50289/overview
Fixed: 376097114,370536090,367426156
Bug: 384394713
Change-Id: I2ab4e43db3de4b7125b564c366fe86bdf9f85cc4
Reviewed-on: https://chromium-review.googlesource.com/6107689
WPT-Export-Revision: dece168b8aea615538bfc98e48f2991215d42541