fix custom assetFileNames issue
#12449
Merged
+43
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
apatel369
commented
Nov 22, 2024
CodSpeed Performance ReportMerging #12449 will improve performances by 19.02%Comparing Summary
Benchmarks breakdown
|
apatel369
force-pushed
the
arpan-#426-adp-customfilename
branch
from
0ad5f7b to
d452c63
Compare
apatel369
changed the title
assetFileNames issue
ematipico
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Thank you @apatel369, sorry for the late review. The fix looks good, I would suggest a better description for merging the PR
improve changeset
Merged
1 task
matthewp
added a commit
that referenced
this pull request
Dec 16, 2024
This reverts commit e6b8017. This change caused source maps to be left in the client folder, exposing them into the server.
ematipico
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Revert "fix custom `assetFileNames` issue (#12449)" (#12746) * Revert "fix custom `assetFileNames` issue (#12449)" This reverts commit e6b8017. This change caused source maps to be left in the client folder, exposing them into the server. * Add changeset * Clean sourcemaps from static output (#12749) * Clean sourcemaps from static output * Add changeset * Update test to look at frontend sourcemaps * Revert "fix custom `assetFileNames` issue (#12449)" (#12746) * Revert "fix custom `assetFileNames` issue (#12449)" This reverts commit e6b8017. This change caused source maps to be left in the client folder, exposing them into the server. * Add changeset * Clean sourcemaps from static output (#12749) * Clean sourcemaps from static output * Add changeset * Update test to look at frontend sourcemaps * [ci] format * fix build * Skip experimental cc tests * remove unused params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
closes #426 in adapters repo
When using custom
assetFileNamesin Astro configuration assets were incorrectly moved to the server directory instead of the client directory. This caused 404 errors when the browser tried to load these assets from the client side.Users could specify custom directories for various asset types (e.g., CSS, images). To handle that used asset paths from the build output to ensure assets are moved from/to the correct directories.
Testing
Added tests for testing image and CSS assets with custom paths.
The previous test was passing cause accidentally
build.assetsand customassetFileNamespath were matching.(
assetsand assets/css)So updated that as well.
Docs
N/A bug fix