Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add article on dimensional analysis #2201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Oblarg
Copy link
Contributor

@Oblarg Oblarg commented Feb 21, 2023

No description provided.

@Oblarg Oblarg force-pushed the add-dimensional-analysis branch from 90d96dd to d70ecae Compare February 21, 2023 00:39
@sciencewhiz
Copy link
Collaborator

sciencewhiz commented Feb 21, 2023

Fixes #1729

@Oblarg Oblarg force-pushed the add-dimensional-analysis branch from d70ecae to 0ff91bc Compare February 21, 2023 00:55
@sciencewhiz
Copy link
Collaborator

I think this would benefit from an example of something everyone uses, converting encoder ticks in the drive train to useful distances

@Starlight220 Starlight220 linked an issue Feb 27, 2023 that may be closed by this pull request
@Starlight220
Copy link
Member

Mention that WPILib uses SI units and strongly advise teams to do the same?

@Daltz333 Daltz333 changed the title add article on dimensional analysis Add article on dimensional analysis Feb 28, 2023
Handling Units in Java
^^^^^^^^^^^^^^^^^^^^^^

Because Java's type system is not really capable of enforcing dimensional correctness at compile-time without major runtime cost and syntax bloat, there's no units library included as part of WPILibJ. This makes managing units in Java somewhat difficult, and even experienced developers will sometimes make mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Because Java's type system is not really capable of enforcing dimensional correctness at compile-time without major runtime cost and syntax bloat, there's no units library included as part of WPILibJ. This makes managing units in Java somewhat difficult, and even experienced developers will sometimes make mistakes.
Because Java's type system is not really capable of enforcing dimensional correctness at compile-time without major runtime cost and syntax bloat, there's no units library included as part of WPILib. This makes managing units in Java somewhat difficult, and even experienced developers will sometimes make mistakes.

We already know this is specific for Java and we don't really mention WPILibJ anywhere else on the site.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is OBE now with wpilibsuite/allwpilib#5371

@Daltz333
Copy link
Member

@Oblarg finishing this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add page on Dimensional Analysis
5 participants