Ensuring the xip extraction will work #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aln787
commented
Sep 14, 2016
aln787
commented
- Adding an alert if the os version is less than 10.11.5. Issue xcpretty#163
KrauseFx
requested changes
Sep 15, 2016
| @@ -48,6 +48,18 @@ def current_symlink | |||
| File.symlink?(SYMLINK_PATH) ? SYMLINK_PATH : nil | |||
| end | |||
|
|
|||
| def os_version_compatibility_issue?(version) | |||
There was a problem hiding this comment.
Could you add some comments here with context on why this is necessary?
There was a problem hiding this comment.
I will add a few comments describing the issue with<10.11.5 failing to extract the archive
There was a problem hiding this comment.
I added a comment. Let me know If you would like me to rebase and submit as a single commit.
| @@ -35,6 +35,7 @@ def validate! | |||
| super | |||
|
|
|||
| help! 'A VERSION argument is required.' unless @version | |||
| fail Informative, 'An OS X version >10.11.4 is required for xcode 8.' if @installer.os_version_compatibility_issue?(@version) | |||
aln787
commented
Oct 6, 2016
| @@ -48,6 +48,18 @@ def current_symlink | |||
| File.symlink?(SYMLINK_PATH) ? SYMLINK_PATH : nil | |||
| end | |||
|
|
|||
| def os_version_compatibility_issue?(version) | |||
There was a problem hiding this comment.
I added a comment. Let me know If you would like me to rebase and submit as a single commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.