Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links for --nc-lk-tx and --nc-ac-tx in dark mode #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

statox
Copy link

@statox statox commented Jul 22, 2020

I think that when setting the colors for dark mode two unknown variables are used and they look like a typo. CSS really is not my strong suit so let me know if I'm wrong.

Amazing framework tho thank you for your work 👍

@vercel
Copy link

vercel bot commented Jul 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/x-z/new-css/1w8hg2441
✅ Preview: https://new-css-git-fork-statox-master.x-z.vercel.app

@statox
Copy link
Author

statox commented Sep 2, 2020

Hi @3x do you have a feedback on this PR? Please let me know if this is incomplete or if it needs additional changes to be accepted. Also note that a new PR is addressing the same typo.

@3x
Copy link
Member

3x commented Sep 2, 2020

Hey @statox, I apologize for being inactive. These variables will be changed in v2.0 with more human-readable names. I'll leave this issue open for reference when 2.0 releases.

@statox statox mentioned this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants