Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically linked libraries with docker support #1190

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

HappyHakunaMatata
Copy link

Added dynamic library generation, so now it's possible to compile the library and use it in your .NET project.
Flags have been replaced with Cobra commands (Docker launch has been maintained).
Added a database to store all data retrieved from the API.

Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awful lot of code and, aside from the functions in src/core, I'm not sure that any of it needs to be in the mainline Yggdrasil distribution. Especially database code, for which it's not clear to me what its purpose is.

@HappyHakunaMatata
Copy link
Author

This is an awful lot of code and, aside from the functions in src/core, I'm not sure that any of it needs to be in the mainline Yggdrasil distribution. Especially database code, for which it's not clear to me what its purpose is.

As I see it, it's currently impossible to save information from the API such as Peer info, etc.(Now it’s only possible to monitor). Moreover, after the session ends, this information is not available in yggdrasilctl, so the database is used to store the data. Dynamic library compilation can be useful if you want to use Yggdrasil in .NET (for example in your ASP NET project you just need to create a custom marshaler). In my opinion Cobra command fits better than Flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants