-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto analyze service tserver and master flags #25097
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some notes together with @yifanguan to try and improve clarity. Some might not be an improvement, @yifanguan to review and apply selectively.
Otherwise looks good from technical perspective.
|
||
##### ysql_enable_auto_analyze_service | ||
|
||
Enable the Auto Analyze service which automatically runs ANALYZEs to update table statistics for tables which have changed more than a configurable threshold. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable the Auto Analyze service which automatically runs ANALYZEs to update table statistics for tables which have changed more than a configurable threshold. | |
Enable the Auto Analyze service, which automatically runs ANALYZE to update table statistics for tables that have changed more than a configurable threshold. |
|
||
{{< note title="Note" >}} | ||
|
||
To fully enable Auto Analyze service, you need to enable `ysql_enable_auto_analyze_service` on all YB-Masters and YB-TServers, as well as `ysql_enable_table_mutation_counter` on all YB-TServers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fully enable Auto Analyze service, you need to enable `ysql_enable_auto_analyze_service` on all YB-Masters and YB-TServers, as well as `ysql_enable_table_mutation_counter` on all YB-TServers. | |
To fully enable the Auto Analyze service, you need to enable `ysql_enable_auto_analyze_service` on all YB-Masters and YB-TServers, and `ysql_enable_table_mutation_counter` on all YB-TServers. |
Default: false | ||
|
||
##### ysql_enable_table_mutation_counter | ||
Enable counting of mutations on a per-table basis. These mutations are used to automatically run ANALYZE as soon as the mutations of a table cross |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable counting of mutations on a per-table basis. These mutations are used to automatically run ANALYZE as soon as the mutations of a table cross | |
Enable mutation counting on a per-table basis. Mutations are used by the Auto Analyze service to run ANALYZE when the number of mutations of a table exceeds |
|
||
##### ysql_enable_table_mutation_counter | ||
Enable counting of mutations on a per-table basis. These mutations are used to automatically run ANALYZE as soon as the mutations of a table cross | ||
a certain threshold (decided based on [ysql_auto_analyze_threshold](#ysql-auto-analyze-threshold) and [ysql_auto_analyze_scale_factor](#ysql-auto-analyze-scale-factor)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a certain threshold (decided based on [ysql_auto_analyze_threshold](#ysql-auto-analyze-threshold) and [ysql_auto_analyze_scale_factor](#ysql-auto-analyze-scale-factor)). | |
the threshold determined by the [ysql_auto_analyze_threshold](#ysql-auto-analyze-threshold) and [ysql_auto_analyze_scale_factor](#ysql-auto-analyze-scale-factor) settings. |
##### ysql_auto_analyze_scale_factor | ||
|
||
The fraction defining when sufficient mutations have been accumulated to run ANALYZE for a table. | ||
ANALYZE runs when the mutation count becomes larger than `ysql_auto_analyze_scale_factor * <table_size> + ysql_auto_analyze_threshold`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ANALYZE runs when the mutation count becomes larger than `ysql_auto_analyze_scale_factor * <table_size> + ysql_auto_analyze_threshold`. | |
ANALYZE runs when the mutation count exceeds `ysql_auto_analyze_scale_factor * <table_size> + ysql_auto_analyze_threshold`. |
|
||
##### ysql_cluster_level_mutation_persist_interval_ms | ||
|
||
Interval at which the reported node level table mutation counts are persisted to the underlying auto-analyze mutations table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the "auto-analyze mutations table"
|
||
##### ysql_cluster_level_mutation_persist_rpc_timeout_ms | ||
|
||
Timeout for the rpcs used to persist mutation counts in the auto-analyze mutations table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timeout for the rpcs used to persist mutation counts in the auto-analyze mutations table. | |
Timeout for the RPCs used to persist mutation counts in the auto-analyze mutations table. |
|
||
##### ysql_node_level_mutation_reporting_interval_ms | ||
|
||
Interval at which the node level table mutation counts are sent to the auto analyze service which tracks table mutation counts at the cluster level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interval at which the node level table mutation counts are sent to the auto analyze service which tracks table mutation counts at the cluster level. | |
Interval, in milliseconds, at which the node-level table mutation counts are sent to the Auto Analyze service, which tracks table mutation counts at the cluster level. |
|
||
##### ysql_node_level_mutation_reporting_timeout_ms | ||
|
||
Timeout for the node level mutation reporting rpc to auto-analyze service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timeout for the node level mutation reporting rpc to auto-analyze service. | |
Timeout, in milliseconds, for the node-level mutation reporting RPC to the Auto Analyze service. |
|
||
##### ysql_enable_auto_analyze_service | ||
|
||
Enable the Auto Analyze service which automatically runs ANALYZEs to update table statistics for tables which have changed more than a configurable threshold. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable the Auto Analyze service which automatically runs ANALYZEs to update table statistics for tables which have changed more than a configurable threshold. | |
Enable the Auto Analyze service, which automatically runs ANALYZE to update table statistics for tables that have changed more than a configurable threshold. |
This pull request add auto analyze service tserver flags
yugabyte-db/docs/content/preview/reference/configuration/yb-tserver.md
and master flags toyugabyte-db/docs/content/preview/reference/configuration/yb-master.md