-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refigure gc tests #612
Refigure gc tests #612
Conversation
3bd21d9
to
1f81c4a
Compare
Replace weak-napi with built in WeakRef
a1715e1
to
cfa3117
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests fail with this error:
TypeError: Converting circular structure to JSON
--> starting at object with constructor 'SourceFileObject'
| property 'statements' -> object with constructor 'Array'
| index 0 -> object with constructor 'NodeObject'
--- property 'parent' closes the circle
at stringify (<anonymous>)
at writeChannelMessage (node:internal/child_process/serialization:159:20)
at process.target._send (node:internal/child_process:845:17)
at process.target.send (node:internal/child_process:745:19)
at /home/runner/work/zeromq.js/zeromq.js/node_modules/.pnpm/[email protected]/node_modules/workerpool/src/worker.js:139:22
That's interesting.... I can see that here. It's failing when trying to send an error from the Typescript compiler. Curious why this didn't turn up earlier...
|
860e75b
to
d00af4e
Compare
Yes, please revert any changes other than the weak-napi changes. Let's get the tests running again. |
I moved these changes to #631 |
Instead of using
weak-napi
, use the built-inWeakRef
.Use the native garbage collector with
{type: 'major', execution: 'async'}
.If gc is not available and GC tests not explicitly skipped, fail test explicitly.