Fixed crash on new Chromium context #678
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address: #663
It persists the default ZMQ Context across Chromium contexts.
I barely understand this stuff, so this may be completely wrong. Also some of the tests fail for worker pools. Not sure if that's my dev environment or an actual issue I've caused 🤷
Draft PR because, like I said, no idea if this is "correct" and should actually be merged yet..