-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: misleading .deployignore
path
#137
Open
dinxsh
wants to merge
16
commits into
main
Choose a base branch
from
fix-deployignore-paths
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinxsh
changed the title
fix(dotnet): misleading .deployignore path
fix: misleading .deployignore path
Dec 22, 2024
dinxsh
changed the title
fix: misleading .deployignore path
fix: misleading Dec 22, 2024
.deployignore
path
vankovap
reviewed
Dec 23, 2024
vankovap
added
♻️ Changes Requested
and removed
🌱 Review me
Add this label whenever you need a review
labels
Dec 23, 2024
dinxsh
added
🌱 Review me
Add this label whenever you need a review
and removed
♻️ Changes Requested
labels
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Type of Change is this?
Description (required)
In Trigger build pipeline pages in all runtimes, there is a
.deployignore
paragraphThe example is slightly misleading. If you put src/file.js in
.deployignore
, it will ignore (i.e., not deploy) all of the following:The correct approach is for the user to always define files in both
.gitignore
and.deployignore
with a / at the beginning if they want to ignore only one specific file and not all files with the same name in all folders.The "root" folder is considered the build folder, i.e., the folder where the user’s app is located (at the same level as the .deployignore file). This is the correct behaviour.
Related issues & labels (optional)