Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misleading .deployignore path #137

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

dinxsh
Copy link
Collaborator

@dinxsh dinxsh commented Dec 22, 2024

What Type of Change is this?

  • New Page
  • Minor Fix
  • Minor Improvement
  • Major Improvement

Description (required)

In Trigger build pipeline pages in all runtimes, there is a .deployignore paragraph

The example is slightly misleading. If you put src/file.js in .deployignore, it will ignore (i.e., not deploy) all of the following:

/src/file.js
/folder2/folder3/src/file.js
/src/src/file.js

The correct approach is for the user to always define files in both .gitignore and .deployignore with a / at the beginning if they want to ignore only one specific file and not all files with the same name in all folders.

The "root" folder is considered the build folder, i.e., the folder where the user’s app is located (at the same level as the .deployignore file). This is the correct behaviour.

Related issues & labels (optional)

@dinxsh dinxsh changed the title fix(dotnet): misleading .deployignore path fix: misleading .deployignore path Dec 22, 2024
@dinxsh dinxsh added the 🌱 Review me Add this label whenever you need a review label Dec 22, 2024
@dinxsh dinxsh marked this pull request as ready for review December 22, 2024 19:22
@dinxsh dinxsh changed the title fix: misleading .deployignore path fix: misleading .deployignore path Dec 22, 2024
@nermalcat69 nermalcat69 requested a review from vankovap December 22, 2024 23:43
@vankovap vankovap added ♻️ Changes Requested and removed 🌱 Review me Add this label whenever you need a review labels Dec 23, 2024
@dinxsh dinxsh requested a review from vankovap December 25, 2024 02:16
@dinxsh dinxsh added 🌱 Review me Add this label whenever you need a review and removed ♻️ Changes Requested labels Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 Review me Add this label whenever you need a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants