Add lint for EV Guidelines section 9.7.3 #815
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks that EV certificates contain a CPS URI policy qualifier
Effective April 10, 2008
aaomidi
approved these changes
Mar 20, 2024
| } | ||
|
|
||
| if !util.HasValidTLD(cps.Hostname(), time.Now()) { | ||
| return &lint.LintResult{Status: lint.Error} |
There was a problem hiding this comment.
Probably fill the details here too
dadrian
approved these changes
Mar 27, 2024
|
@mcpherrinm can you fix the failing test (looks like counts changed given logic change)? Once that's resolved, we can merge. |
|
Yep, will take a look soon. Busy with RWC this week :) |
|
Sounds good! Hope RWC is fun! Bummed I'm missing out this year. |
aaomidi
reviewed
Apr 19, 2024
| LintMetadata: lint.LintMetadata{ | ||
| Name: "e_ev_certificate_policies", | ||
| Description: "EV Certificates issued to Subscribers MUST include a CPS URI policy qualifier", | ||
| Citation: "CA/Browser Forum EV Guidelines v1.8.1, Sec. 9.7.3", |
There was a problem hiding this comment.
I think this has now changed to 7.1.4.3: https://github.com/cabforum/servercert/blob/main/docs/EVG.md#7143-additional-technical-requirements-for-ev-certificates
|
This looks like it's been open for a while modulo a test. @mcpherrinm any chance you'd be willing to look at the failing test? |
|
Sorry, totally forgot about this PR. I'll take a look at that test shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that EV certificates contain a CPS URI policy qualifier.
The CPS URI should be a public HTTP URI.
This requirement was included explicitly in the EV guidelines version 1.2, effective April 10, 2008