Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'archive_branch' option to the GitHub Action #48

Merged
merged 1 commit into from
Mar 29, 2021
Merged

added 'archive_branch' option to the GitHub Action #48

merged 1 commit into from
Mar 29, 2021

Conversation

mattecapu
Copy link
Contributor

Added an option to address Issue #46

@logankilpatrick
Copy link

Would be awesome to get this merged given the tool to re-name the default branch has rolled out across GitHub.

@timabbott timabbott merged commit ba5a492 into zulip:master Mar 29, 2021
@timabbott
Copy link
Member

Merged, sorry for the slow review! This is a low-activity repository that thus is my job to manage, and a baby joined my family in November :).

@logankilpatrick
Copy link

Congrats! Hope your staying safe.

@mattecapu
Copy link
Contributor Author

Thanks @timabbott! I appreciate the time you put in this, there was no hurry :) congrats for the kid!

@SaschaMann
Copy link

I've renamed the branch and added the new input to the workflow, but now this error occurs:

error: src refspec main does not match any.
error: failed to push some refs to '***github.com/JuliaCommunity/zulip-archive'

(see https://github.com/JuliaCommunity/zulip-archive/runs/2240461747?check_suite_focus=true)

The only reference to master that I can still find in this repo is in github.py:

zulip-archive/github.py

Lines 18 to 21 in ba5a492

# resets the current repository to match origin/master
def github_pull():
print(subprocess.check_output(['git','fetch','origin','master']))
print(subprocess.check_output(['git','reset','--hard','origin/master']))

I don't think that file is called from the action, but I might be wrong.

Do you have an idea what could cause this or how to fix it?

@mattecapu
Copy link
Contributor Author

I guess it's caused by delete_history recreating the Git repo from scratch with the wrong name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants