Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore: Ignore CMake directory generated on Android build #1221

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Dec 27, 2024

Starting with our last Flutter update 273674f (#1184), a directory android/app/.cxx/ gets created whenever building or running the app for Android. It has a lot of generated files in it.

See chat discussion:
https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/Error.20in.20running.20the.20app/near/2017805
https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/.2Ecxx.2F.20files.20created/near/2017819

There's an upstream issue for the need to add a gitignore line for these in the flutter create templates:
flutter/flutter#160372

Even when that's done, it won't affect existing apps like ours; we need to make a similar update in our own tree. That's this commit.

Starting with our last Flutter update 273674f (zulip#1184), a directory
android/app/.cxx/ gets created whenever building or running the app
for Android.  It has a lot of generated files in it.

See chat discussion:
  https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/Error.20in.20running.20the.20app/near/2017805
  https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/.2Ecxx.2F.20files.20created/near/2017819

There's an upstream issue for the need to add a gitignore line for
these in the `flutter create` templates:
  flutter/flutter#160372

Even when that's done, it won't affect existing apps like ours; we
need to make a similar update in our own tree.  That's this commit.
@gnprice gnprice added the maintainer review PR ready for review by Zulip maintainers label Dec 27, 2024
@chrisbobbe chrisbobbe self-requested a review December 27, 2024 21:36
@chrisbobbe chrisbobbe self-assigned this Dec 27, 2024
@chrisbobbe
Copy link
Collaborator

LGTM; I plan to merge once CI passes.

@chrisbobbe chrisbobbe merged commit 3ff7096 into zulip:main Dec 27, 2024
1 check passed
@gnprice gnprice deleted the pr-cxx-gitignore branch December 27, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants