[core] Config V2 & deprecate unused code #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leecchh
reviewed
Dec 2, 2024
leecchh
reviewed
Dec 2, 2024
| @@ -15,7 +15,7 @@ | |||
| /// useful for system-level discounts, or user-specific discounts. | |||
| /// | |||
| /// TODO: Consider re-using `RequestData` inside the `Receipt`. | |||
| /// TODO: Add settings for max year of renewals / max duration of registration here? | |||
| /// TODO: Add settings for max year of renewals / max duration of registration here? | |||
There was a problem hiding this comment.
I like this but let's include in a separate PR
leecchh
approved these changes
Dec 2, 2024
manolisliolios
changed the title
leecchh
reviewed
Dec 2, 2024
manolisliolios
commented
Dec 20, 2024
| } | ||
| } | ||
|
|
||
| public fun default(): CoreConfig { |
There was a problem hiding this comment.
make this test_only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a minor restructure of the codebase to deprecate what's not needed.
That (for now) includes:
update_image.move: We have proceeded with a different design overall.config.move: I created aCoreConfigwhich is more flexible for future updates, and covers all our current needs. (please seetodopoint for discussion).auction.move: I kept the auction codebase (and actually ported it to our new config), but decided to move it to the deprecated folder to remove confusion. This system is no longer usable.Additional changes:
payments_versionin the configuration: This allows us to preventPaymentIntentfrom being finalized if it does not match the "configured" version from admin.Follow-ups:
I also wanna re-write
controller.moveto do whateverdirect_setuppackage does. There's no reason for us not to offer the basic functionality from our core package, now that we know that the basics will (most likely) never change. We can always deauthorize it too so thats also good news 😄Tests fail because of
renewal, register and discount_housepackages. I leave them here on purpose to avoid merge conflicts down the path. Their rewrite is coming up too.