implement URLPattern #785
Open
implement URLPattern #785
+5,212
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
from
89f46f0 to
02492e1
Compare
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
from
0ccd6d3 to
d2cd4f8
Compare
|
@anonrig Just to confirm... is this the spec? https://urlpattern.spec.whatwg.org |
Yes that's correct @lemire |
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
3 times, most recently
from
e51503f to
524cb73
Compare
jasnell
reviewed
Dec 4, 2024
jasnell
reviewed
Dec 4, 2024
jasnell
reviewed
Dec 4, 2024
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
from
1a98cc9 to
18ef1a6
Compare
|
I don't particular mind, but please be aware that you are changing the coding convention. The C++ standard library uses all-lowercase with underscores names. You are using Camel case. If you merge this, it will mean that within the same library, we mix two conventions. |
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
3 times, most recently
from
380d57e to
880e260
Compare
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
5 times, most recently
from
51690eb to
010bc69
Compare
…into yagiz/add-url-pattern
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
from
b893367 to
7393441
Compare
* adding some optional logging of the parse results * guarding * mark it as used * fixed ECMAScript qualification --------- Co-authored-by: Daniel Lemire <[email protected]>
| std::regex_constants::syntax_option_type flags{}; | ||
| std::regex regexp{}; | ||
| std::regex_constants::syntax_option_type flags = std::regex::ECMAScript; | ||
| std::regex regexp{"*"}; |
There was a problem hiding this comment.
here I saw that wpt_urlpattern_tests.has_regexp_groups test passes when we use .* for ecmascript compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements URLPattern from scratch. I'm adding
TODO: Optimization opportunitynotes in places I think an optimization can be done. The goal is to merge this once there is noTODO: Implement thiscomments.TODOs
TODO: Implement thisoccurrences (currently 4)url_pattern::match