m-site-p 3.21+ #561
Draft
m-site-p 3.21+ #561
+245
−261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-1224
to
-1236
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-site-plugin</artifactId> | ||
| <version>${commons.site-plugin.version}</version> | ||
| <configuration> | ||
| <!-- Exclude the navigation file for Maven 1 sites | ||
| and the changes file used by the changes-plugin, | ||
| as they interfere with the site generation. --> | ||
| <moduleExcludes> | ||
| <xdoc>navigation.xml,changes.xml</xdoc> | ||
| </moduleExcludes> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
there is no reports in m-site-p
| <action type="update">commons.release-plugin.version: 1.5 -> 1.6</action> | ||
| <action type="update">commons.spotbugs.version: 3.1.3 -> 3.1.6</action> | ||
| <action type="update">japicmp-maven-plugin: 0.12.0 -> 0.13.0</action> | ||
| <action type="update" dev="">commons.build-plugin.version: 1.9 -> 1.10</action> |
There was a problem hiding this comment.
dev attribute is required ... it was also required in old schema but not verified ...
There was a problem hiding this comment.
Hello @slawekjaranowski
Thank you for creating this PR and putting in the work.
How about making the dev attribute optional for 3.0.0-M2? Absent or "" is the same IMO. Otherwise, that's a lot of mindless editing of 20+ changes.xml files in Commons... :-(
There was a problem hiding this comment.
plugin will be works ... only checking xml will be break - you don't need change it
but it is good idea to make it optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo