Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Many of our typehints are wrong. This adds
beartype
based type checks during runtime and staticmypy
checks to prevent this.Proposed changes
This adds some risk, as it might lead to a less frequently visited code part with a minor type error crashing our codebase during a game. We could downgrade the errors to warnings, but then they might not be noticed/ignored. We could also deactivate them during real games, but we do not have a mechanic to check for this yet.
We need to test this on the real robot before merging it!
Checklist
colcon build