Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vizualizer] for LeRobodDataset V2 #576

Merged
merged 37 commits into from
Dec 20, 2024
Merged

Conversation

mishig25
Copy link
Contributor

@mishig25 mishig25 commented Dec 13, 2024

Description

https://huggingface.co/spaces/lerobot/visualize_dataset is already using this branch

As we discussed offline, this PR updates the visualizer to use v2 datasets and merge all the visualizer changes from https://huggingface.co/spaces/lerobot/visualize_dataset fork into lerobot repository

Usage

# start a server with homepage will fetch datasets hosted remotely on hf.co/datasets
python lerobot/scripts/visualize_dataset_html.py
image
# start a server with specific dataset (by default it will download parquet & video files locally AND start the visualizer server)
python lerobot/scripts/visualize_dataset_html.py --repo-id lerobot/aloha_static_ziploc_slide
image
# start a server with specific dataset without downloading parquet & video files locally (instead the visualizer server will fetch the dataset hosted remotely on hf.co/dataasets) `-load-from-hf-hub 1` arg
python lerobot/scripts/visualize_dataset_html.py --repo-id lerobot/aloha_static_ziploc_slide --load-from-hf-hub 1

besides the v2 dataset, further improvements were added to vizualizer

  1. using the specified motor names
    see example here
image
  1. refactored the code in a way that would let us easily add more columns to the data table
    After merging this PR, I will add [viz tool] add policy pred column #529

@mishig25 mishig25 marked this pull request as ready for review December 16, 2024 11:16
@mishig25
Copy link
Contributor Author

cc: @aliberts @Cadene ready to review

@@ -1,30 +0,0 @@
#!/usr/bin/env python
Copy link
Contributor Author

@mishig25 mishig25 Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test file was removed since the entire functionality was removed. I added changes from #387 to this PR

Copy link
Collaborator

@aliberts aliberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @mishig25!
Left a non-blocking comment, feel free to follow or merge directly

@@ -20,7 +20,8 @@
from itertools import accumulate
from pathlib import Path
from pprint import pformat
from typing import Any
from types import SimpleNamespace
from typing import Any, Dict, Iterator
Copy link
Collaborator

@aliberts aliberts Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: since we're using python >=3.10 we don't need typing.Dict and we can type-hint directly with dict.
Similarly, typing.Iterator is deprecated and can be replaced by collections.abc.Iterable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handled in c425bd8

@mishig25
Copy link
Contributor Author

I pushed c425bd8 that makes it use the modern types.

@aliberts please feel free to merge since I don't have premissions to merge it even though the PR was approved

@aliberts
Copy link
Collaborator

Sure thing, thanks!

@aliberts aliberts merged commit 73b64c3 into huggingface:main Dec 20, 2024
5 checks passed
villekuosmanen added a commit to villekuosmanen/lerobot that referenced this pull request Dec 30, 2024
* feat: enable to use multiple rgb encoders per camera in diffusion policy (huggingface#484)

Co-authored-by: Alexander Soare <[email protected]>

* Fix config file (huggingface#495)

* fix: broken images and a few minor typos in README (huggingface#499)

Signed-off-by: ivelin <[email protected]>

* Add support for Windows (huggingface#494)

* bug causes error uploading to huggingface, unicode issue on windows. (huggingface#450)

* Add distinction between two unallowed cases in name check "eval_" (huggingface#489)

* Rename deprecated argument (temporal_ensemble_momentum) (huggingface#490)

* Dataset v2.0 (huggingface#461)

Co-authored-by: Remi <[email protected]>

* Refactor OpenX (huggingface#505)

* Fix missing local_files_only in record/replay (huggingface#540)

Co-authored-by: Simon Alibert <[email protected]>

* Control simulated robot with real leader (huggingface#514)

Co-authored-by: Remi <[email protected]>

* Update 7_get_started_with_real_robot.md (huggingface#559)

* LerobotDataset pushable to HF from any folder (huggingface#563)

* Fix example 6 (huggingface#572)

* fixing typo from 'teloperation' to 'teleoperation' (huggingface#566)

* [vizualizer] for LeRobodDataset V2 (huggingface#576)

* Fix broken `create_lerobot_dataset_card`  (huggingface#590)

* feat(act): support training end of episode token to ACT model

* changes

* feat(arx): add arx arm (#2)

* feat(arx): support arx arm

* changes

* changes

* changes

* changes

* pass pipes explicitly

* changes

* us ndarray over a pipe

* changes

* changes

* replay basically works

* patch arx sdk

* changes

* support cameras in arx5

* rename to arx5

* kind of works

* changes

* changes

* changes

* various changes

* changes

* revert a few changes

* changes

* changes

* changes

* changes

* changes

* changes

* changes

* changes

* changes

* remove TODO

* allow multiple tasks

---------

Signed-off-by: ivelin <[email protected]>
Co-authored-by: Hirokazu Ishida <[email protected]>
Co-authored-by: Alexander Soare <[email protected]>
Co-authored-by: Arsen Ohanyan <[email protected]>
Co-authored-by: Ivelin Ivanov <[email protected]>
Co-authored-by: Daniel Ritchie <[email protected]>
Co-authored-by: resolver101757 <[email protected]>
Co-authored-by: Jannik Grothusen <[email protected]>
Co-authored-by: KasparSLT <[email protected]>
Co-authored-by: Simon Alibert <[email protected]>
Co-authored-by: Remi <[email protected]>
Co-authored-by: Michel Aractingi <[email protected]>
Co-authored-by: Simon Alibert <[email protected]>
Co-authored-by: berjaoui <[email protected]>
Co-authored-by: Claudio Coppola <[email protected]>
Co-authored-by: s1lent4gnt <[email protected]>
Co-authored-by: Mishig <[email protected]>
Co-authored-by: Eugene Mironov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants