Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add SubscriptionSink::connection_id #1175

Merged
merged 1 commit into from
Aug 10, 2023
Merged

feat(server): add SubscriptionSink::connection_id #1175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/server/subscription.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,11 @@ impl SubscriptionSink {
self.method
}

/// Get the connection ID.
pub fn connection_id(&self) -> ConnectionId {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Different topic: Would it also be possible to identify the client connected by this ConnectionID? (paritytech/substrate#14734)

Copy link
Member Author

@niklasad1 niklasad1 Aug 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that should work but the connection IDs may be reused once the connection is dropped and the counter wraps.

I guess that could handled when the subscription is dropped then just remove it from a HashMap or something

self.uniq_sub.conn_id
}

/// Send out a response on the subscription and wait until there is capacity.
///
///
Expand Down